Differential D17877

Handle query prepare errors in QueryBuilder::exec
ClosedPublic
Actions

Authored by modax on Dec 30 2018, 6:32 PM.

Details

Reviewers
dvratil
Group Reviewers
KDE PIM
Commits
R165:3e47fbc309fa: Handle query prepare errors in QueryBuilder::exec
Summary

It is way better to handle these errors here as early as possible. It
means seeing error descriptions which actually make sense (in e.g. SQLite
case, when SQLite limits or syntax errors are hit) and probably it should
help to avoid nasty crashes later on in exec() phase.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
modax created this revision.Dec 30 2018, 6:32 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 30 2018, 6:32 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
modax requested review of this revision.Dec 30 2018, 6:32 PM
dvratil accepted this revision.Dec 30 2018, 7:14 PM
dvratil added a subscriber: dvratil.

Looks good, thanks!

Do you have commit access? If not, I can push the patch for you.

This revision is now accepted and ready to land.Dec 30 2018, 7:14 PM
modax added a comment.Dec 30 2018, 7:35 PM

Thanks! I don't have commit access, please land the patch for me.

Closed by commit R165:3e47fbc309fa: Handle query prepare errors in QueryBuilder::exec (authored by modax, committed by dvratil). · Explain WhyJan 4 2019, 5:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48681

View Options

src/server/storage/querybuilder.cpp

Loading...