Fix SQL syntax error in findOrphanedItems()
ClosedPublic

Authored by modax on Dec 30 2018, 6:23 PM.

Details

Summary

SQL UPDATE does not support full field name:

PimItemTable.collectionId = :0

vs

collectionId = :0

in its SET part.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
modax created this revision.Dec 30 2018, 6:23 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 30 2018, 6:23 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
modax requested review of this revision.Dec 30 2018, 6:23 PM
modax edited the summary of this revision. (Show Details)Dec 30 2018, 6:25 PM
dvratil accepted this revision.Dec 30 2018, 7:15 PM
dvratil added a subscriber: dvratil.

Should go to Applications/18.12 (stable) branch.

This revision is now accepted and ready to land.Dec 30 2018, 7:15 PM
modax added a comment.Dec 30 2018, 7:36 PM

Do I need to do anything to change base branch to 'Applications/18.12 (stable)'? I don't have commit access, please land the patch on my behalf :)

This revision was automatically updated to reflect the committed changes.