[dimdisplay] Effectively waits display to wake-up
ClosedPublic

Authored by anthonyfieroni on Dec 30 2018, 4:40 PM.

Details

Summary

This is 2nd patch of fixes annoying side effect (D16918 was first one), yeah about me it's not a bug but it depend of driver even on display reaction time. I try to wake-up by simulating activity, but that may not enough, so delay screen brightness gives a little bit time to display to react.

Test Plan

What the side effect is:

  1. Dimm display and screen energy saving are enabled
  2. Let's time activation in configuration of energy saving is longer
  3. Unplug adapter
  4. Wait to dimming to set screen to 0
  5. If now wake-ups screen - all is good screen is not goes to sleep
  6. So we wait to screen saving to be activated
  7. Now screen sleeps, just plug adapter in makes screen to wake-up
  8. If dimm action sets screen brightness too early is just ignored (by driver or display who knows)

Diff Detail

Repository
R122 Powerdevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
anthonyfieroni created this revision.Dec 30 2018, 4:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 30 2018, 4:40 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
anthonyfieroni requested review of this revision.Dec 30 2018, 4:40 PM

Does someone test it, @thsurrel ?

Sorry I did not have any time to test this, but I am really interested to see the result. I am back from my holidays now, I should be able to test tomorrow.

abetts added a subscriber: abetts.Jan 3 2019, 4:02 PM

Can you pleas provide a video showing the annoying behavior? Just to make sense of it.

anthonyfieroni added a comment.EditedJan 3 2019, 4:17 PM

Video can't handle it. (i've think about screencast but can be recorded by a phone)

Laptop at this configuration, screen brightness < 100%, waits more that 10 min inactivity, plug-in adapter will wake-up screen with brightness at 100%, which unwanted especially at night hours.

abetts added a comment.Jan 3 2019, 4:21 PM

Video can't handle it. (i've think about screencast but can be recorded by a phone)

Laptop at this configuration, screen brightness < 100%, waits more that 10 min inactivity, plug-in adapter will wake-up screen with brightness at 100%, which unwanted especially at night hours.

This works. Thanks for the clarification.

The problem is too specific, it happen when dpms is activated after dimm display is setted screen to 0, if dimm option is not checked it works correct to me.

broulik accepted this revision.Jan 10 2019, 1:23 PM
This revision is now accepted and ready to land.Jan 10 2019, 1:23 PM
This revision was automatically updated to reflect the committed changes.