The Windows port now enables the desktop to ring when "Ring" is called via the complimenting device
Details
Details
- Reviewers
apol albertvaka - Group Reviewers
KDE Connect
- install phonon-VLC backend: craft -i phonon-vlc
- Apply patch, build and test for Windows- call "Ring" from the three-dot menu in Android application
Diff Detail
Diff Detail
- Repository
- R224 KDE Connect
- Branch
- master
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 6465 Build 6483: arc lint + arc unit
Comment Actions
Thank you for reviewing, Aleix! But this one has already been accepted and
committed by nicolas. I'm sorry I should have closed the patch here earlier
🤧
Comment Actions
Thank you for reviewing this, Aleix.
I made an MR at invent later, and it has already been committed by Nicolas.
I'm sorry, I missed to close it here.
Comment Actions
In the file findthisdevice_config.cpp there is the same defaultSound() function. It needs to be changed there as well or, ideally, use the same function from both files instead of duplicating it.