Add Windows support to findthisdevice/Ring plugin

Authored by brute4s99 on Dec 29 2018, 9:16 PM.


Group Reviewers
KDE Connect

The Windows port now enables the desktop to ring when "Ring" is called via the complimenting device

Test Plan
  1. install phonon-VLC backend: craft -i phonon-vlc
  2. Apply patch, build and test for Windows- call "Ring" from the three-dot menu in Android application

Diff Detail

R224 KDE Connect
Lint OK
No Unit Test Coverage
Build Status
Buildable 6465
Build 6483: arc lint + arc unit
brute4s99 created this revision.Dec 29 2018, 9:16 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 29 2018, 9:16 PM
brute4s99 requested review of this revision.Dec 29 2018, 9:16 PM

so if we are on Windows, the file "C:/Windows/media/Ring01.wav" will be used!

brute4s99 edited the test plan for this revision. (Show Details)Dec 29 2018, 9:19 PM
brute4s99 retitled this revision from Added Windows support to findthisdevice/Ring plugin to Add Windows support to findthisdevice/Ring plugin.Dec 30 2018, 7:24 AM
apol accepted this revision.Feb 20 2019, 5:16 PM
This revision is now accepted and ready to land.Feb 20 2019, 5:16 PM

Thank you for reviewing, Aleix! But this one has already been accepted and
committed by nicolas. I'm sorry I should have closed the patch here earlier

brute4s99 added a comment.EditedFeb 20 2019, 7:49 PM

Thank you for reviewing this, Aleix.
I made an MR at invent later, and it has already been committed by Nicolas.
I'm sorry, I missed to close it here.

albertvaka requested changes to this revision.Feb 22 2019, 6:43 PM
albertvaka added a subscriber: albertvaka.

In the file findthisdevice_config.cpp there is the same defaultSound() function. It needs to be changed there as well or, ideally, use the same function from both files instead of duplicating it.

This revision now requires changes to proceed.Feb 22 2019, 6:43 PM