KMines Reset After Game Over.
ClosedPublic

Authored by smaudet on Dec 29 2018, 7:48 PM.

Details

Summary

At the end of the game you are prompted to restart the same or continue to a new one.

You have the option of saying 'no' - besides that unless you're in a competition I don't think it should matter. Mainly I proposed the change because there are times when its impossible to do anything but guess (not even statistics) and this is a midway between a 'reveal' button and just flat out spending 4 minutes on something and failing.

Diff Detail

Repository
R404 KMines
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
smaudet created this revision.Dec 29 2018, 7:48 PM
Restricted Application added a reviewer: KDE Games. · View Herald TranscriptDec 29 2018, 7:48 PM
Restricted Application added a subscriber: kde-games-devel. · View Herald Transcript
smaudet requested review of this revision.Dec 29 2018, 7:48 PM

Thanks in advance for fixing the issue.

mainwindow.cpp
207

This should be QMessageBox::question(this, i18n("Reset?"), i18n("Reset the Game?")

mlaurent requested changes to this revision.Dec 29 2018, 10:01 PM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
mainwindow.cpp
207

indeed we use i18n in this program

This revision now requires changes to proceed.Dec 29 2018, 10:01 PM
mlaurent added inline comments.Dec 30 2018, 8:39 AM
scene.cpp
78

coding style: add \n after ()

smaudet updated this revision to Diff 48454.Dec 31 2018, 5:21 PM
smaudet marked 2 inline comments as done.

Yes I have fixed the i18n problem.

I took the time also to add some additional toggles to the program based on various concerns people had expressed.

mainwindow.cpp
207

Yes I have fixed the i18n problem.

I took the time also to add some additional toggles to the program based on various concerns people had expressed.

smaudet updated this revision to Diff 48455.Dec 31 2018, 5:28 PM
smaudet marked 2 inline comments as done.

Tested. Work exactly as explained in the description.

The only thing is this question mark in the window header. Is it allowed by our HIG?

mainwindow.cpp
207

Trailing space.

scene.cpp
78

Trailing space.

smaudet updated this revision to Diff 48483.Jan 1 2019, 5:13 PM
smaudet marked 2 inline comments as done.

Tested. Work exactly as explained in the description.

The only thing is this question mark in the window header. Is it allowed by our HIG?

It's not expressly forbidden, but in general the best header text avoids simply re-stating the words used in the description below.

mlaurent accepted this revision.Jan 2 2019, 6:09 AM

For me it seems ok now

This revision is now accepted and ready to land.Jan 2 2019, 6:09 AM
aacid added a subscriber: aacid.Jan 2 2019, 10:17 PM

He doesn't have a commiter account, Sebastian we're going to need your email so someone can commit this to git properly.

This revision was automatically updated to reflect the committed changes.