Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11
ClosedPublic

Authored by eduisters on Dec 29 2018, 7:30 PM.

Details

Summary

PreferenceActivity has been deprecated since Android 3.0 API 11 in favour of PreferenceFragment

Before
After
Test Plan

Apply patch and observe that the DeviceSettings and PluginSettings screen behave as expected
and now also follow material design guidelines

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Dec 29 2018, 7:30 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 29 2018, 7:30 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Dec 29 2018, 7:30 PM
eduisters edited the summary of this revision. (Show Details)Dec 29 2018, 7:38 PM
eduisters added a reviewer: KDE Connect.
eduisters updated this revision to Diff 48484.Jan 1 2019, 5:30 PM
  • Fix NPE
eduisters updated this revision to Diff 48514.Jan 2 2019, 10:52 AM
  • Improved state saving
nicolasfella accepted this revision.Jan 5 2019, 7:03 PM
This revision is now accepted and ready to land.Jan 5 2019, 7:03 PM
eduisters added inline comments.Jan 5 2019, 7:13 PM
src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneSettingsFragment.java
76

Typo: not => no

src/org/kde/kdeconnect/UserInterface/PluginSettingsFragment.java
60

Typo: delete call

eduisters marked 2 inline comments as done.Jan 6 2019, 11:25 AM
This revision was automatically updated to reflect the committed changes.