Differential D17856

Fix a regression introduced in 6a1852
ClosedPublic
Actions

Authored by vandenoever on Dec 29 2018, 5:27 PM.

Details

Reviewers
dfaure
arichardson
apol
aacid
ngraham
Commits
R237:f403d09d0b49: Fix a regression introduced in 6a1852
Summary

Bytes from 'Strings' of type GroupString and KeyString should not be
escaped because they are valid UTF-8. Only instances of ValueString
should be escaped.

This fixes the failing test KConfigTest::testEncoding

Test Plan

Ran ninja test and found no errors.

Diff Detail

Repository
R237 KConfig
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vandenoever created this revision.Dec 29 2018, 5:27 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptDec 29 2018, 5:27 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vandenoever requested review of this revision.Dec 29 2018, 5:27 PM
apol accepted this revision.Dec 30 2018, 3:56 AM
This revision is now accepted and ready to land.Dec 30 2018, 3:56 AM
Closed by commit R237:f403d09d0b49: Fix a regression introduced in 6a1852 (authored by vandenoever). · Explain WhyDec 30 2018, 12:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/kconfigini.cpp (7 lines)

Diff 48393

View Options

src/core/kconfigini.cpp

Loading...