Differential D17852

ViewInternal: Fix 'Go to matching bracket' in override mode
ClosedPublic
Actions

Authored by loh.tar on Dec 29 2018, 12:21 PM.

Details

Reviewers
dhaumann
Group Reviewers
KTextEditor
Commits
R39:1e0ace28c795: ViewInternal: Fix 'Go to matching bracket' in override mode
Summary

BUG: 402594

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
loh.tar created this revision.Dec 29 2018, 12:21 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 29 2018, 12:21 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
loh.tar requested review of this revision.Dec 29 2018, 12:21 PM
dhaumann added a subscriber: dhaumann.Jan 8 2019, 7:28 PM

I think this change makes sense.

I would like to have a unit test for this. Doing so is simple: Add a function in autotest/src/kateview_test.h/cpp and add one bracket matching call, then check the new cursor position. Then, do the same in overwrite mode.

loh.tar added a comment.Jan 8 2019, 8:03 PM

Nice trick ;-) Can't promise to do it, will see

loh.tar updated this revision to Diff 49530.Jan 15 2019, 2:16 PM

Add autotest

dhaumann accepted this revision.Jan 15 2019, 5:27 PM

Good patch, and works for me.

This revision is now accepted and ready to land.Jan 15 2019, 5:27 PM

Revision Contents
Changeset List

Diff 49530

View Options

autotests/src/kateview_test.h

Loading...
View Options

autotests/src/kateview_test.cpp

Loading...
View Options

src/view/kateviewinternal.cpp

Loading...