[server] Don't assert when destroying a still referenced BufferInterface
ClosedPublic

Authored by graesslin on Jun 7 2016, 6:31 AM.

Details

Summary

The fact that the buffer is still referenced - that is used - when the
BufferInterface gets destroyed is an error, but it is not fatal.

Unfortunately KWin/Wayland is still hitting this assert from time to
time and the assert is not helping to find the cause as a backtrace
does not show where a reference is still hold.

This change removes the hard assert by a soft warning. The advantage
of the warning is that the compositor is not killed and that we can
observe the reason and find a usage pattern which triggers the condition.

With that we will hopefully be able to find the case where the buffer
is still referenced when being destroyed and fix that.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4263.Jun 7 2016, 6:31 AM
graesslin retitled this revision from to [server] Don't assert when destroying a still referenced BufferInterface.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma on Wayland.
graesslin added a reviewer: Plasma.
graesslin added a subscriber: plasma-devel.
sebas accepted this revision.Jun 13 2016, 8:57 PM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Jun 13 2016, 8:57 PM
This revision was automatically updated to reflect the committed changes.