Differential D17822

Fix send to KDE Connect for older KDE Connect version
ClosedPublic
Actions

Authored by nicolasfella on Dec 27 2018, 4:45 PM.

Details

Reviewers
vkrause
Group Reviewers
KDE PIM: KMail
Commits
R81:787dbfe2ba5e: Fix send to KDE Connect for older KDE Connect version
R81:f22c28a3a747: Fix send to KDE Connect for older KDE Connect version
Summary

When I wrote the code I assumed that by the time it is released the corresponding KDE Connect changes would be released, too. History proved me wrong. The openFile method will only be available with KDE Connect 1.4 whose release
is not yet scheduled.

For older versions of KDE Connect shareUrl is used now. That transfers the file but does not open it.

Test Plan

Tested with KDE Connect 1.3.3 and master (with version bumped to 1.4).

Diff Detail

Repository
R81 KDE PIM Addons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Dec 27 2018, 4:45 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 27 2018, 4:45 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
nicolasfella requested review of this revision.Dec 27 2018, 4:45 PM
vkrause accepted this revision.Dec 27 2018, 5:31 PM
This revision is now accepted and ready to land.Dec 27 2018, 5:31 PM
Closed by commit R81:f22c28a3a747: Fix send to KDE Connect for older KDE Connect version (authored by nicolasfella). · Explain WhyDec 27 2018, 5:46 PM
This revision was automatically updated to reflect the committed changes.
nicolasfella added a comment.Jan 5 2019, 5:52 PM

I'd like to also land this in stable since otherwise a broken feature is exposed. Is that ok?

vkrause added a comment.Jan 5 2019, 5:54 PM
In D17822#387035, @nicolasfella wrote:

I'd like to also land this in stable since otherwise a broken feature is exposed. Is that ok?

Sure!

Revision Contents
Changeset List

Diff 48257

View Options

plugins/messageviewer/bodypartformatter/semantic/semanticurlhandler.cpp

Loading...