Added button to close the tab individually
AbandonedPublic

Authored by marssola on Dec 26 2018, 9:27 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole

Diff Detail

Repository
R319 Konsole
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6374
Build 6392: arc lint + arc unit
marssola created this revision.Dec 26 2018, 9:27 PM
Restricted Application added a project: Konsole. · View Herald TranscriptDec 26 2018, 9:27 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
marssola requested review of this revision.Dec 26 2018, 9:27 PM
marssola abandoned this revision.Dec 26 2018, 9:49 PM

Excuse me!!! I made a wrong commit.

Either way, I'm glad someone is working on this. Having only a single close button way off to the side seems really weird and nonstandard.

hindenburg added a subscriber: hindenburg.

This patch isn't good - you are creating new files. It is easiest if you use arc (once you have it setup).

Can you try to fix the patch?

https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches