Check icon positions after move
ClosedPublic
Actions

Authored by McPain on Dec 26 2018, 2:54 PM.

Details

Reviewers

hein

Group Reviewers

Plasma

Commits

R119:e2aa89898db3: Check icon positions after move

Summary

BUG: 402574

When we're moving a bunch of icons to the area which is already busy, we didn't check whether we're moving icons to different places.

Now we check additionally if we're moving icon to the place already taken by previously moved icons.

Repository

R119 Plasma Desktop

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

McPain requested review of this revision.Dec 26 2018, 2:54 PM

Looks sensible to me. Good stuff.
Wait a week to allow Eike a chance to comment, otherwise consider this a ship it!

Fixed condition mistake

containments/desktop/plugins/folder/positioner.cpp
418	AFAIK, the first part of condition is "check if `to` is blank and if it's not, check whether we're not moving icon to itself, and if we do, it's alright" The second part is "check if we're already moving another icon to `to` and if we do so, try `to+1`"

hein accepted this revision.Jan 2 2019, 7:39 AM

This revision is now accepted and ready to land.Jan 2 2019, 7:39 AM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			containments/desktop/plugins/folder/positioner.cpp (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	48220			Dec 26 2018, 2:48 PM	★	★
Diff 2	48238			Dec 27 2018, 8:06 AM	★	★
Diff 3	50560	aaebb51	R119:e2aa89898db3bfe05f0af1a1ab064542f095620f	Jan 30 2019, 3:22 PM	★	★