Differential D17786

[Receivenotification] Support long text
ClosedPublic
Actions

Authored by nicolasfella on Dec 24 2018, 9:46 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:4dec2898f48c: [Receivenotification] Support long text
Summary

Use bigtext style.

BUG: 402489

Test Plan

Send notification with long text. Before a single line was shown. Now the user can view the full content by pulling down the notification

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Dec 24 2018, 9:46 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 24 2018, 9:46 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
nicolasfella requested review of this revision.Dec 24 2018, 9:46 PM
nicolasfella edited the summary of this revision. (Show Details)Dec 24 2018, 9:46 PM
albertvaka accepted this revision.Dec 24 2018, 9:53 PM
This revision is now accepted and ready to land.Dec 24 2018, 9:53 PM
albertvaka added a comment.Dec 24 2018, 9:54 PM

Maybe set empty string as a default? Null ticker might break the bigtext?

nicolasfella added a comment.Dec 24 2018, 9:59 PM
In D17786#381948, @albertvaka wrote:

Maybe set empty string as a default? Null ticker might break the bigtext?

We check np.has("ticker") before, so it can't be null, can it?

nicolasfella added a comment.Dec 24 2018, 10:03 PM

Even with null it doesn't break

Closed by commit R225:4dec2898f48c: [Receivenotification] Support long text (authored by nicolasfella). · Explain WhyDec 24 2018, 10:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48162

View Options

src/org/kde/kdeconnect/Plugins/ReceiveNotificationsPlugin/ReceiveNotificationsPlugin.java

Loading...