Ignoring virtual PA devices for volume control results in ignoring the
"Simultaneous output" devices. This makes it impossible to control them
with the volume keys, which is not what the user expects. As a workaround,
prefer not to ignore virtual devices that are marked as default.
Details
Details
- Reviewers
broulik drosca - Commits
- R115:5dc7cca58a72: Don't ignore default virtual devices
Diff Detail
Diff Detail
- Repository
- R115 Plasma Audio Volume Applet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
src/pulseaudio.cpp | ||
---|---|---|
300 | Missing Space: ) && |
Comment Actions
Fixed. I'm not sure if I need to press a button or something to request another review though.
Comment Actions
For context, I filed the bug report (https://bugs.kde.org/show_bug.cgi?id=395466) and then David fixed it in D13568.
Since I don't think PulseEffects becomes the default device, this should be fine.
Comment Actions
Thanks for the review. Can you submit it for me? My KDE developer account is disabled, probably because of years of inactivity.
Comment Actions
Should this be cherry-picked onto the stable branch so it makes it into the upcoming 5.15 release?