Don't change alternate scrolling state after calling reset()
ClosedPublic

Authored by ahmadsamir on Dec 24 2018, 7:28 PM.

Details

Summary

Alternate Scrolling shouldn't be reset when calling resetModes(), this
is to maintain the profile alternate scrolling property after reset()
is called, otherwise calling reset() (or clear scrollback and reset)
will always make alternate scrolling get disabled regardless of the
respective profile property.

Also this matches XTerm behavior.

BUG: 402461

Test Plan

1 - Open a new tab and make sure the alternate scrolling profile property

is enabled

2 - Run less or any other application that uses the alternate screen,

scrolling with the mouse should work

3 - Quit the previous application and execute reset
4 - Repeat 2, notice that now scrolling doesn't work

After applying the patch, alternate scrolling mode is not changed after
calling reset.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ahmadsamir created this revision.Dec 24 2018, 7:28 PM
Restricted Application added a project: Konsole. · View Herald TranscriptDec 24 2018, 7:28 PM
ahmadsamir requested review of this revision.Dec 24 2018, 7:28 PM
hindenburg edited the test plan for this revision. (Show Details)Dec 25 2018, 1:20 AM
hindenburg accepted this revision.Dec 25 2018, 1:38 AM

Thanks, FYI using vim works for testing - not sure why less doestn't use alternative screen on my system

This revision is now accepted and ready to land.Dec 25 2018, 1:38 AM
This revision was automatically updated to reflect the committed changes.