Differential D17773

Copy to Clipboard in English
ClosedPublic
Actions

Authored by guoyunhe on Dec 24 2018, 9:45 AM.

Details

Reviewers
ngraham
Group Reviewers
Plasma
Commits
R102:937e9c72fe94: Copy to Clipboard in English
Summary

Add a new button to copy to clipboard in English for usage in bug report. This
doesn't affect existing copy button which copy translated information for usage in local
forum, etc.

Copied example:

Operating System: openSUSE Tumbleweed 20181219
KDE Frameworks Version: 5.53.0
Qt Version: 5.12.0
Kernel Version: 4.19.8-1-default
OS Type: 64-bit
Processors: 8 × Intel® Core™ i7-4710MQ CPU @ 2.50GHz
Memory: 7.7 GiB

Diff Detail

Repository
R102 KInfoCenter
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6320
Build 6338: arc lint + arc unit
guoyunhe created this revision.Dec 24 2018, 9:45 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 24 2018, 9:45 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Dec 24 2018, 9:45 AM
guoyunhe edited the summary of this revision. (Show Details)Dec 24 2018, 9:47 AM
guoyunhe added a reviewer: Plasma.
guoyunhe updated this revision to Diff 48124.Dec 24 2018, 12:53 PM
guoyunhe edited the summary of this revision. (Show Details)

Hide the "Copy to Clipboard in English" button when the system is already in English.

ngraham accepted this revision.Dec 24 2018, 6:07 PM
ngraham added a subscriber: ngraham.

Much better. This seems sensible to me.

This revision is now accepted and ready to land.Dec 24 2018, 6:07 PM
Closed by commit R102:937e9c72fe94: Copy to Clipboard in English (authored by Guo Yunhe <i@guoyunhe.me>). · Explain WhyDec 24 2018, 8:54 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.EditedJan 18 2019, 5:18 PM

BTW I just discovered that this caused a regression: https://bugs.kde.org/show_bug.cgi?id=403368

It's currently publicly visible at https://blog.neon.kde.org/index.php/2019/01/17/test-kde-plasma-5-15-beta-with-neon/ :p

davidedmundson added a subscriber: davidedmundson.Jan 18 2019, 6:44 PM

How can this affect discover?

ngraham added a comment.Jan 18 2019, 7:19 PM

Oops, wrong bug. Too many tabs open... Correcting the original comment now.

Revision Contents
Changeset List

Diff 48111

View Options

Modules/about-distro/src/Module.h

Loading...
View Options

Modules/about-distro/src/Module.cpp

Loading...
View Options

Modules/about-distro/src/Module.ui

Loading...