[kcmkwin/desktop] Add animation option back
ClosedPublic

Authored by zzag on Dec 23 2018, 4:34 PM.

Details

Summary

The "new" animation option no longer uses hard coded effects, which
means one could install a third party virtual desktop switching animation,
for example from store.kde.org, and it will be displayed in the KCM.

Test Plan

Diff Detail

Repository
R108 KWin
Branch
extract-effects-model
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6450
Build 6468: arc lint + arc unit
zzag created this revision.Dec 23 2018, 4:34 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 23 2018, 4:34 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 23 2018, 4:34 PM
zzag updated this revision to Diff 48085.Dec 23 2018, 5:23 PM

fix initial index

UI looks pretty good, and thanks for doing this!

Could we move this to above the "Show on-screen display when switching" checkbox? That way we would have the two "Show <something> when switching" items visually grouped together.

zzag updated this revision to Diff 48087.Dec 23 2018, 5:38 PM

Move "show animation" before "show osd"

zzag edited the test plan for this revision. (Show Details)Dec 23 2018, 5:38 PM
zzag retitled this revision from [kcmkwin/kwindesktop] Add animation option back to [kcmkwin/desktop] Add animation option back.
ngraham accepted this revision.Dec 23 2018, 8:50 PM
This revision is now accepted and ready to land.Dec 23 2018, 8:50 PM
zzag updated this revision to Diff 48344.Dec 29 2018, 12:44 PM

Use QLatin1String instead of QStringLiteral.

zzag updated this revision to Diff 48349.Dec 29 2018, 1:21 PM

Use Status enum

ngraham added a subscriber: hein.Jan 7 2019, 11:43 AM
zzag edited the summary of this revision. (Show Details)Jan 7 2019, 1:27 PM

Two minor things, but in general ship it!

kcmkwin/kwindesktop/package/contents/ui/main.qml
222

Generally
onActivated

is better as that is only user changes.

onCurrentIndexChanges has quirky issues if you ever make that model load asyncronously or whatever as it constantly rebounds.
Might not occur right now, but worth future proofing.

kcmkwin/kwindesktop/virtualdesktops.cpp
241

I assume you've seen https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0
as you're using the QPointer on the exec'ing dialog, but you need to check here in the branch where dialog is rejected.

zzag updated this revision to Diff 48964.Jan 8 2019, 1:45 PM

David's comments.

zzag marked 2 inline comments as done.Jan 8 2019, 1:45 PM
davidedmundson accepted this revision.Jan 8 2019, 1:48 PM
This revision was automatically updated to reflect the committed changes.