[kcmkwin] Move effects model into a shared library
ClosedPublic

Authored by zzag on Dec 23 2018, 4:33 PM.

Details

Summary

The main motivation for moving it into a shared library is to share the
model between Desktop Effects and Virtual Desktops KCM.

The extracted model is quite the same as the one in Desktop Effects KCM,
except some minor changes, e.g. rename loadEffect and syncConfig to more
convenient names, add comments, some whitespace changes, fix coding
style in some parts, etc.

Test Plan

effectModelTest passes, Desktop Effects KCM works.

Diff Detail

Repository
R108 KWin
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6297
Build 6315: arc lint + arc unit
zzag created this revision.Dec 23 2018, 4:33 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 23 2018, 4:33 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 23 2018, 4:33 PM
zzag updated this revision to Diff 48080.Dec 23 2018, 4:41 PM

Remove unnecessary linking against kwin4_effect_builtins

zzag updated this revision to Diff 48081.Dec 23 2018, 4:48 PM

Cleanup includes

zzag updated this revision to Diff 48082.Dec 23 2018, 4:51 PM

More cleanup

zzag updated this revision to Diff 48083.Dec 23 2018, 4:55 PM

Cleanup unusued includes

zzag retitled this revision from [kcmkwin] Extract effects model into a shared library to [kcmkwin] Move effects model into a shared library.Dec 23 2018, 6:23 PM
zzag updated this revision to Diff 48089.Dec 23 2018, 6:38 PM

fix links

zzag updated this revision to Diff 48342.Dec 29 2018, 12:24 PM
  • Edit docs;
  • Some small code improvements.
zzag updated this revision to Diff 48343.Dec 29 2018, 12:36 PM
  • Delete unused includes;
  • Use more auto.
zzag updated this revision to Diff 48348.Dec 29 2018, 1:21 PM

Rename EffectStatus enum to Status

EffectModel::EffectStatus::{Enabled,Disabled} looks very awkward.

zzag updated this revision to Diff 48350.Dec 29 2018, 1:30 PM

Rename EffectRoles to AdditionalRoles

The main motivation is to get rid of potential duplication of the effect word

ngraham added a subscriber: hein.Jan 7 2019, 11:42 AM
zzag updated this revision to Diff 48912.Jan 7 2019, 8:24 PM

Edit comments.

zzag updated this revision to Diff 48914.Jan 7 2019, 8:33 PM

Capitalize "in" in "Builtin"

davidedmundson accepted this revision.Jan 8 2019, 1:28 PM
This revision is now accepted and ready to land.Jan 8 2019, 1:28 PM
This revision was automatically updated to reflect the committed changes.