Differential D17762

Add building instructions using Docker
ClosedPublic
Actions

Authored by dfaure on Dec 23 2018, 2:46 PM.

Details

Reviewers
apol
vkrause
Commits
R1007:0d24aa076720: Add building instructions using Docker
Test Plan

Works

Diff Detail

Repository
R1007 Itinerary - Travel Assistance Application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Dec 23 2018, 2:46 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptDec 23 2018, 2:46 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
dfaure requested review of this revision.Dec 23 2018, 2:46 PM
mlaurent added a subscriber: mlaurent.Dec 23 2018, 3:23 PM

cool :)
+1 for me.
I keep @vkrause gives you a +2 :)

vkrause accepted this revision.Dec 23 2018, 4:33 PM
This revision is now accepted and ready to land.Dec 23 2018, 4:33 PM
apol added inline comments.Dec 24 2018, 4:08 AM
README.md
22

It shouldn't be necessary to pass -DQTANDROID_EXPORTED_TARGET=itinerary-app. Do you get an error or something otherwise?

FWIW, it's not necessary for on the binary-factory builds.

dfaure marked an inline comment as done.Dec 24 2018, 11:32 AM
dfaure added inline comments.
README.md
22

You're right. Removed.

Closed by commit R1007:0d24aa076720: Add building instructions using Docker (authored by dfaure). · Explain WhyDec 24 2018, 11:33 AM
This revision was automatically updated to reflect the committed changes.
dfaure marked an inline comment as done.

Revision Contents
Changeset List

PathPackages
MREADME.md (11 lines)

Diff 48115

View Options

README.md

Loading...