Differential D17758

Disable KDE ServerDecoration on Qt > 5.12
ClosedPublic
Actions

Authored by davidedmundson on Dec 23 2018, 1:40 PM.

Details

Reviewers
graesslin
Group Reviewers
KWin
Plasma
Commits
R135:ee2663b8f43f: Disable KDE ServerDecoration on Qt > 5.12
Summary

XdgDecoration is built into QtWayland 5.12. Running two interfaces to do
the same thing would be messy.

We cannot just remove this code as Plasma 5.15 will depend on Qt5.11.

Detection of the ShellSurfaceInterface was used to test if we have run
shellSurfaceCreated which we still need for other functions, so this check
is replaced with a new explicit property.

Test Plan

Got the correct decorations still.
I haven't tested on Qt5.11. I would appreciate someone checking that
things still work the same.

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 23 2018, 1:40 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 23 2018, 1:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 23 2018, 1:41 PM
graesslin accepted this revision.Dec 23 2018, 6:45 PM
graesslin added a subscriber: graesslin.

I still have Qt 5.11, so I'll try to compile the change and give it a try.

src/platformtheme/kwaylandintegration.cpp
127

PlasmaIntegration is compile time bound, right?

This revision is now accepted and ready to land.Dec 23 2018, 6:45 PM
Closed by commit R135:ee2663b8f43f: Disable KDE ServerDecoration on Qt > 5.12 (authored by davidedmundson). · Explain WhyJan 1 2019, 8:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48492

View Options

src/platformtheme/kwaylandintegration.cpp

Loading...