Remove full representation of analog clock
AbandonedPublic

Authored by shubham on Dec 23 2018, 12:15 PM.

Details

Reviewers
hein
mart
Group Reviewers
VDG
Summary

Full representation of analog clock showed a calendar, which does not makes sense for two reasons:

  1. It shows a massive calendar which clogs the window and looks ugly.

  1. User can click in the system tray instead.
Test Plan

Create analog clock widget. Try to click on it.
Nothing happens.

Diff Detail

Repository
R120 Plasma Workspace
Branch
cal
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6282
Build 6300: arc lint + arc unit
shubham created this revision.Dec 23 2018, 12:15 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 23 2018, 12:15 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
shubham requested review of this revision.Dec 23 2018, 12:15 PM
shubham edited the summary of this revision. (Show Details)Dec 23 2018, 12:26 PM
User can click in the system tray instead.

Not if they have the analog clock in the system tray instead

mart added a comment.Jan 7 2019, 4:36 PM

-1, digital and analog clocks have the same scope, and they should have the same behavior (if anything it should have the same features of the digital clock popup)

abetts added a subscriber: abetts.Jan 7 2019, 4:42 PM

I think part of the reason why this seems too big also if because it doesn't do much more than tell you what day it is. If it was able to integrate with a calendar application, it could show appointments. Something like this:

https://goo.gl/images/rwgUw9

mart added a comment.Jan 7 2019, 4:46 PM

I think part of the reason why this seems too big also if because it doesn't do much more than tell you what day it is. If it was able to integrate with a calendar application, it could show appointments. Something like this:

https://goo.gl/images/rwgUw9

the popup of the digital clock does that, what's the actual problem is that the analog and digital clocks aren't on par with features

shubham abandoned this revision.Jan 7 2019, 4:53 PM

Abandon in favor of above discussion.