Use KFileWidget instead of QFileDialog
ClosedPublic

Authored by jgrulich on Dec 22 2018, 5:01 PM.

Details

Summary

It would be used anyway, because QFileDialog in Plasma uses KFileWidget through QPA

Diff Detail

Repository
R838 Flatpak Support: KDE Portal for XDG Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jgrulich created this revision.Dec 22 2018, 5:01 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 22 2018, 5:01 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich requested review of this revision.Dec 22 2018, 5:01 PM

This still doesn't resolve bug 399889 so review https://phabricator.kde.org/D17677 will be still needed.

https://phabricator.kde.org/D17677 will be still needed.

My rule about working round KDE code still applies.

Does this work: https://phabricator.kde.org/P285 on KIO for the remaining case?

src/filechooser.cpp
287

.arg(QString,QString) not arg(QString).arg(QString)

It can change behaviour if the first inserted string contains the literal "%2"

302
304–305

const

jgrulich updated this revision to Diff 48029.Dec 22 2018, 8:26 PM

Use QScopedPointer for file dialogs

Yes, it does work with your patch, thank you for that and sorry for my laziness.

davidedmundson accepted this revision.Dec 22 2018, 9:37 PM
This revision is now accepted and ready to land.Dec 22 2018, 9:37 PM
This revision was automatically updated to reflect the committed changes.