Introduce an initial state event into Plasma Window protocol
ClosedPublic

Authored by graesslin on Jun 6 2016, 10:45 AM.

Details

Summary

The event is sent to the client once all initial state is transmitted.
This means the client is able to see the PlasmaWindow completely created
and not in the intermediate state with further updates being pushed after
being created.

The client side API is adjusted to emit the windowCreated signal after
the initial state event is received. In addition if the window is already
unmapped, the signal will never be emitted which means the not valid
windows are not exposed to the client at all.

The tests are adjusted to reflect the new reality, which in most cases
just means removing the comment that this needs to be improved.

There is one kind of unrelated change included: when an empty icon is
set, the client side now creates a QIcon() instead of going through
QIcon::fromTheme. This wrong behavior was exposed now by the auto tests.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4232.Jun 6 2016, 10:45 AM
graesslin retitled this revision from to Introduce an initial state event into Plasma Window protocol.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: Plasma, hein.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 6 2016, 10:45 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Jun 6 2016, 10:52 AM
hein edited edge metadata.
This revision is now accepted and ready to land.Jun 6 2016, 10:52 AM
This revision was automatically updated to reflect the committed changes.