Details
- Reviewers
dhaumann cullmann - Group Reviewers
KTextEditor - Commits
- R39:5dde33b16bca: KateStatusBar: Reformatted by astyle command to follow coding style
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Lint Skipped - Unit
Unit Tests Skipped
+1
I think this is fine, but let Christoph and Dominik decide if we want style fixing commits.
- It's a prearrangement for more changes D17730
- In the meantime I noticed that these astyle command did not move/fix to place "*&" to the right. I will update/fix this before someone like to commit
- Run astyle again, this time with "--align-pointer=name"
- Omit changes done in the signal/slot connect code because these need a port to the new style. Well, was somehow pointless because these code is changed anyway but I noticed that too late :-/
I am fine with that.
Actually, if there is a astyle commandline that enforces the right style, could you paste it here?
I am in favor of some script that runs that over the repo and just applying that regularly to enforce it stays sane, that is much more useful than to review each ( placement in all commits ;=)
@cullmann wrote:
Actually, if there is a astyle commandline that enforces the right style, could you paste it here?
Um (?) I had in mind it was on the Kate HP but couln'd find it now. But it's there https://community.kde.org/Policies/Kdelibs_Coding_Style#Artistic_Style_.28astyle.29_automatic_code_formatting
As said I add "--align-pointer=name" but don't like to change this wiki, as noob :-)
Furthermore I noticed that it is still not full coding style conform due to not fixed "one line conditional statements", so "--add-braces" may an option but I didn't try it
I am in favor of some script that runs that over the repo and just applying that regularly to enforce it stays sane, that is much more useful than to review each ( placement in all commits ;=)
In generally a good idea. But sometimes it's nice to break the coding style to achieve some more lovely look