Copy to clipboard always copy English texts
AbandonedPublic

Authored by guoyunhe on Dec 20 2018, 8:14 AM.

Details

Reviewers
davidedmundson
ngraham
Group Reviewers
Plasma
Summary

Usually users copy this info to report bugs or get help from community. English texts are more useful and readable.

Diff Detail

Repository
R102 KInfoCenter
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6206
Build 6224: arc lint + arc unit
guoyunhe created this revision.Dec 20 2018, 8:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 20 2018, 8:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
guoyunhe requested review of this revision.Dec 20 2018, 8:14 AM
cfeck added a subscriber: cfeck.Dec 20 2018, 3:15 PM

If I understand your patch correctly, you only forbid translating the order of text, not the actual text labels.

If I understand your patch correctly, you only forbid translating the order of text, not the actual text labels.

Yes, the patch doesn't do what I want to do. I will update it.

guoyunhe updated this revision to Diff 47897.EditedDec 20 2018, 4:27 PM

Use untranslated texts for clipboard label pairs

Here is the copy of my system information:

Operating System: openSUSE Tumbleweed 20181214
KDE Frameworks version: 5.52.0
Qt version: 5.12.0
Kernel version: 4.19.7-1-default
Operating System type: 64-bit
Processor: 4 × Intel® Core™ i5-6500 CPU @ 3.20GHz
Memory: 11.6 GiB of RAM

I recall in the original patch that copying translated text was something that various folks specifically asked for. Is it really that useless? @gregormi, do you remember the context?

I recall in the original patch that copying translated text was something that various folks specifically asked for. Is it really that useless? @gregormi, do you remember the context?

If both translated and untranslated texts are used by some people, I can make another button "Copy to clipboard (English)".

cfeck added a comment.Dec 20 2018, 5:16 PM

Or make the button have a drop-down, see e.g. "Save As..." button in Spectacle.

Hi, here is the discussion around my the patch that introduced the Copy button: https://phabricator.kde.org/D7087

Originally, I proposed the untranslated English text. Those are the reasons that lead to the fact that we have the translated version: https://phabricator.kde.org/D7087#207123. Both, the translated and untranslated version are useful. We just chose one of those options. To me, having both options (with and without translation) makes sense.

My original suggestion had a generic drop down menu (burger menu icon) where the copy action was put. Since the menu contained only one action in the end, it was dropped.

Thanks @gregormi.

I could see a split button working well here.

Here is another solution. https://phabricator.kde.org/D17773

Don't affect current button but add a new one. Since here are only two buttons and enough space, I didn't use dropdown or split button.

ngraham accepted this revision.Dec 24 2018, 3:26 PM

Much better. This seems sensible to me.

This revision is now accepted and ready to land.Dec 24 2018, 3:26 PM
ngraham resigned from this revision.Dec 24 2018, 6:08 PM

Oops, approved the wrong patch. Meant to approve D17773.

This revision now requires review to proceed.Dec 24 2018, 6:08 PM
davidedmundson requested changes to this revision.May 17 2019, 12:11 AM
davidedmundson added a subscriber: davidedmundson.

Am I right that this can be closed as D17773 obsoletes this.

Please reopen this if it's still relevant.

This revision now requires changes to proceed.May 17 2019, 12:11 AM

Yes, this can be closed because another approach is more useful.

guoyunhe abandoned this revision.Sep 16 2019, 11:59 AM