Differential D17689

[RFC] Positioner: call initMaps even if m_enabled == false
AbandonedPublic
Actions

Authored by McPain on Dec 19 2018, 2:36 PM.

Details

Reviewers
hein
davidedmundson
Group Reviewers
Plasma
Summary

BUG: 401023
After fresh installation if user tries to create an icon (file or dir) it won't create his own phantom copy

Before patch:

After patch:

I don't really know why it fixes the problem, found a fix by accident.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
McPain created this revision.Dec 19 2018, 2:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 19 2018, 2:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
McPain requested review of this revision.Dec 19 2018, 2:36 PM
ngraham retitled this revision from Positioner: call initMaps even if m_enabled == false to [RFC] Positioner: call initMaps even if m_enabled == false.Dec 19 2018, 2:38 PM
ngraham edited the summary of this revision. (Show Details)
ngraham added a reviewer: Plasma.
hein added a comment.EditedDec 19 2018, 3:14 PM

Thanks for your submission. Could you provide a description for this patch? What does it fix, why does it fix it?

McPain edited the summary of this revision. (Show Details)Dec 20 2018, 10:51 AM
hein added a comment.Dec 20 2018, 10:54 AM

Cool, thanks for the update. I'm a bit flooded before the Christmas holidays, but I'll try to make sense of this in early 2019.

McPain added a comment.Jan 10 2019, 8:30 AM
In D17689#379900, @hein wrote:

Cool, thanks for the update. I'm a bit flooded before the Christmas holidays, but I'll try to make sense of this in early 2019.

ping?

hein added a comment.Jan 11 2019, 12:22 PM

Thanks for the ping, it worked :)

I'm looking into this today. I won't be able to accept this patch as-is, because it's working around the real problem. But it definitely helps in finding it!

McPain added a comment.EditedJan 14 2019, 8:32 AM
In D17689#391265, @hein wrote:

Here's my take: https://phabricator.kde.org/D18182

is it intentional you mentioned *this* review, not https://phabricator.kde.org/D17707?

McPain abandoned this revision.Jan 14 2019, 9:09 AM

Revision Contents
Changeset List

Diff 47850

View Options

plasma-desktop/containments/desktop/plugins/folder/positioner.cpp

Loading...