Differential D17679

CMake: skip server entries without empty build system information
ClosedPublic
Actions

Authored by mwolff on Dec 19 2018, 9:27 AM.

Details

Reviewers
apol
Group Reviewers
KDevelop
Commits
R32:2da988ae2a36: CMake: skip server entries without empty build system information
Summary

In one of my work projects, the CMake 3.13.1 server gave fileGroups
responses without any useful CMakeFile data. This then was stored
in our lookup hash used by CMakeManager::fileInformation.

Then later, when we queried for these files, we found a match,
albeit empty, and returned that leading to completely broken C++
language support.

To prevent this issue, we now skip useless empty CMakeFile entries.
This fixes the specific scenario I'm seeing in my work project.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff created this revision.Dec 19 2018, 9:27 AM
Restricted Application added a project: KDevelop. · View Herald TranscriptDec 19 2018, 9:27 AM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
mwolff requested review of this revision.Dec 19 2018, 9:27 AM
apol accepted this revision.Dec 19 2018, 3:57 PM
apol added a subscriber: apol.

Danke!

This revision is now accepted and ready to land.Dec 19 2018, 3:57 PM
Closed by commit R32:2da988ae2a36: CMake: skip server entries without empty build system information (authored by mwolff). · Explain WhyDec 20 2018, 10:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47881

View Options

plugins/cmake/cmakeprojectdata.h

Loading...
View Options

plugins/cmake/cmakeserverimportjob.cpp

Loading...