remove wrapper script
ClosedPublic

Authored by bam on Dec 18 2018, 7:33 PM.

Details

Summary

if special "xdg-data" string is used for shared path,
we have no need for the wrapper any more,
since that shared path is also mounted within $XDG_DATA_HOME inside sandbox

Diff Detail

Repository
R256 Flatpak packaging for KDE Applications
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6184
Build 6202: arc lint + arc unit
bam requested review of this revision.Dec 18 2018, 7:33 PM
bam created this revision.
bam added a comment.Dec 18 2018, 7:45 PM

Sorry, I'm new to Arcanist.
I need to publish the commits for review separately.
Please, help

bam updated this revision to Diff 47803.Dec 18 2018, 10:44 PM

list helper script in manifest

bam edited the summary of this revision. (Show Details)Dec 18 2018, 10:47 PM
bam updated this revision to Diff 47805.Dec 18 2018, 11:03 PM

with lint

bam added a reviewer: apol.Dec 18 2018, 11:10 PM
bam added a project: Discover Software Store.
apol added a comment.Dec 19 2018, 12:14 AM

Why is this better? please provide a better description.

org.kde.discover.json
143

Don't put this last, this will break binary-factory builds.

bam updated this revision to Diff 47848.EditedDec 19 2018, 2:19 PM

addresses binary-factory build

bam marked an inline comment as done.Dec 19 2018, 2:22 PM
bam added a comment.Dec 19 2018, 2:34 PM
In D17662#379187, @apol wrote:

Why is this better? please provide a better description.

@apol well, I believe it makes navigating and editing more easily, and better corresponds to idea of having all needed information to build the software in one manifest file.
The wrapper role is too minor for pushing it to a separate file.
I wish it wouldn't be needed at all, but we just have to keep it due restrictions flatpak has currently.

apol added a comment.Dec 19 2018, 4:01 PM

You are just renaming it and moving it around.

bam added a comment.Dec 19 2018, 4:06 PM

The clue part here is removing the wrapper.sh file.
Also, I don't think we should make a separate module just for the wrapper.

bam added inline comments.Dec 19 2018, 4:08 PM
org.kde.discover.json
143

Will that build in binary-factory?

bam added a comment.Dec 19 2018, 4:15 PM

Also, there is other improvement such as 'exec'

bam added a comment.Dec 19 2018, 4:16 PM

... and using FLATPAK_USER_DIR instead of XDG_DATA_HOME

bam added a comment.Dec 21 2018, 11:00 AM

@apol Last but not least, you could give me a New Year present accepting this patch :-P

apol accepted this revision.Dec 22 2018, 12:55 AM
This revision is now accepted and ready to land.Dec 22 2018, 12:55 AM
bam updated this revision to Diff 48094.Dec 23 2018, 9:07 PM
bam retitled this revision from list helper script in manifest to remove wrapper script.
bam edited the summary of this revision. (Show Details)

remove wrapper script

bam updated this revision to Diff 48099.Dec 23 2018, 10:25 PM
bam edited the summary of this revision. (Show Details)

minor corrections

bam updated this revision to Diff 48116.Dec 24 2018, 12:15 PM

rebase

Closed by commit R256:3e28c7cdc899: remove wrapper script (authored by bam, committed by apol). · Explain WhyJan 14 2019, 6:45 PM
This revision was automatically updated to reflect the committed changes.