Set parent window for dialogs
ClosedPublic
Actions

Authored by volkov on Dec 18 2018, 4:22 PM.

Details

Reviewers

jgrulich
apol

Commits

Summary

This requires fix in Qt to work for standard dialogs:
https://codereview.qt-project.org/#/c/248559/

Repository

R838 Flatpak Support: KDE Portal for XDG Desktop

Branch

Plasma/5.14

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 6143
Build 6161: arc lint + arc unit

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

volkov requested review of this revision.Dec 18 2018, 4:22 PM

LGTM, I also missed this!

Maybe it would make sense to add a TODO about implementing it for Wayland?

This revision is now accepted and ready to land.Dec 18 2018, 6:17 PM

We can backport the patch to the runtime when it gets accepted, so we'll have all it takes.

src/utils.h
24	This might as well be a `namespace`?

In D17659#379007, @apol wrote:

LGTM, I also missed this!

Maybe it would make sense to add a TODO about implementing it for Wayland?

Is it possible to implement support for foreign windows in KWin QPA plugin?

In D17659#379912, @volkov wrote:

Is it possible to implement support for foreign windows in KWin QPA plugin?

There is no such thing as a KWin QPA.

In D17659#389728, @volkov wrote:

I mean this plugin: https://cgit.kde.org/kwin.git/tree/plugins/qpa

That is KWin's own plugin. No binary except KWin can use it.

Oh, I see.