Redraw the slider if modes have changed
AbandonedPublic

Authored by amantia on Dec 18 2018, 3:58 PM.

Details

Reviewers
dvratil
Summary

This can happen if a monitor was not configured at all, the KCM is shown
when it first plugged in and the user selects to not configure it.
In the UI it will appear with no Resolution/Refresh rate and wrong size in
the QML view.

Depends on D17657

Diff Detail

Repository
R104 KScreen
Branch
fix_null_size
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6175
Build 6193: arc lint + arc unit
amantia created this revision.Dec 18 2018, 3:58 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 18 2018, 3:58 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
amantia requested review of this revision.Dec 18 2018, 3:58 PM
davidedmundson added inline comments.
kcm/src/resolutionslider.cpp
144

does this not cause the apply button to enable immediately when a user hasn't changed anything?

amantia added inline comments.Dec 18 2018, 6:51 PM
kcm/src/resolutionslider.cpp
144

I don't see how it would do that. This is called either when an output is set up the first time or when the modes (not the current mode, but how many resolutions it supports) changes.

amantia updated this revision to Diff 47830.Dec 19 2018, 9:48 AM
  • Show unconnected displayed at the left
amantia updated this revision to Diff 47831.Dec 19 2018, 9:49 AM

Undo last change