Differential D17649

Let docbookl10nhelper executable name follow conventions of checkXML on Windows
Needs RevisionPublic
Actions

Authored by habacker on Dec 18 2018, 9:27 AM.

Details

Reviewers
pino
Summary

FIXED-IN:5.54
BUG:373928

Diff Detail

Repository
R238 KDocTools
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6125
Build 6143: arc lint + arc unit
habacker created this revision.Dec 18 2018, 9:27 AM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptDec 18 2018, 9:27 AM
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. · View Herald Transcript
habacker requested review of this revision.Dec 18 2018, 9:27 AM
ltoscano added a subscriber: ltoscano.Dec 18 2018, 9:43 AM

The file is not meant to be installed (unless INSTALL_INTERNAL_TOOLS is exported), and in general it should not exist in the same build root of its kdelibs 4.x counterpart.

habacker added a comment.Dec 18 2018, 10:30 AM
In D17649#378737, @ltoscano wrote:

The file is not meant to be installed (unless INSTALL_INTERNAL_TOOLS is exported), and in general it should not exist in the same build root of its kdelibs 4.x counterpart.

This tools is required for cross compiling kdoctools https://build.opensuse.org/package/show/home:rhabacker:branches:windows:mingw:win64:KF547/mingw64-kdoctools and therefore installed. obs has KDE4 and KF5 packages side by side

habacker added a comment.Dec 21 2018, 7:33 AM

On opensuse there are the cross compile helper packages

mingw32-cross-kde4-tools
mingw32-cross-kf5-tools

both containing docbookl10nhelper and nothing prevents them from been installed in parallel

pino requested changes to this revision.Dec 21 2018, 8:23 AM
pino added a subscriber: pino.
In D17649#380233, @habacker wrote:

On opensuse there are the cross compile helper packages

mingw32-cross-kde4-tools
mingw32-cross-kf5-tools

both containing docbookl10nhelper and nothing prevents them from been installed in parallel

Nothing says that both must be installed at the same time. Just add conflicts to these packages against each other, so it is clearly marked that they are not coinstallable.
Furthermore, as already mentioned in D17650: Install kioslave.exe as kioslave5.exe under Windows, just focus the efforts on KF5 stuff, instead of wasting work to make umbrello & alkimia dual Qt4/Qt5, and adding more features to a stable Qt4 branch (4.8) of kmymoney.

This revision now requires changes to proceed.Dec 21 2018, 8:23 AM

Revision Contents
Changeset List

PathPackages
Msrc/CMakeLists.txt (3 lines)

Diff 47756

View Options

src/CMakeLists.txt

Loading...