[kcmkwin/kwinrules] Don't include kdeglobals in rules config
ClosedPublic

Authored by davidedmundson on Dec 17 2018, 9:00 PM.

Details

Summary

There's nothing relevant in kdeglobals and loading it can lead to noise
when deleting groups that override a system default.

We still cascade which will allow kiosk keys to work as well as relevant
system defaults.

Import/Export is unchanged as that already uses SimpleConfig which
includes this flag.

I don't know if it will fix the relevant issue in the bug or just
reduce noise.

CCBUG: 402139

Test Plan

Compiled.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 17 2018, 9:00 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 17 2018, 9:00 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
davidedmundson requested review of this revision.Dec 17 2018, 9:00 PM
zzag accepted this revision.Dec 19 2018, 11:48 AM
zzag added a subscriber: zzag.
zzag added inline comments.
data/update_default_rules.cpp
43

While we're on this, could you please remove a whitespace between the open parenthesis and "kwinrulesrc"?

This revision is now accepted and ready to land.Dec 19 2018, 11:48 AM
davidedmundson marked an inline comment as done.Dec 19 2018, 1:07 PM
This revision was automatically updated to reflect the committed changes.