| vonreth |
MSVC allows co-installing multiple version of the compiler and
vcvarsall.bat will use the latest one by default. This patch adds
a new configuration option that allows user to choose an older toolset
to use.
This is useful when trying to reproduce a build failure against an older
version of MSVC.
Tested locally to force 14.14.26428 toolset while having 14.16.something installed.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Besides nit picking and the fear of confused users it looks good :) thx
| CraftSettings.ini.template | ||
|---|---|---|
| 19 | Please state that this is an expert option and should not be touched if one does not exactly know what it means :) | |
| bin/CraftSetupHelper.py | ||
| 189–194 | for a better overview pls set the default value at the beginning of the function | |
Sorry, I somehow forgot to hit the "Submit" button :facepalm:
| bin/CraftSetupHelper.py | ||
|---|---|---|
| 189–194 | That would break the logic below: we only want to specify the vcvars_ver when the toolset option is set: setting it to 14.0 at the beginning of the function would pick the wrong toolset when none were specified in the configuration. | |
your right, bust till please mark the setting as don't touch if you don't know what your doing ^^