Make libpanes a static library
ClosedPublic

Authored by heikobecker on Dec 16 2018, 7:41 PM.

Details

Summary

add_library uses the value of BUILD_SHARED_LIBS to decide wether to
build a static or dynamic lib. If it is on, libpane is built but not
installed, which causes kookbook to fail on start, complaining about
"error while loading shared libraries: libpanes.so: cannot open
shared object file: No such file or directory".
Instead make it a static lib.

Test Plan

kookbook starts fine

Diff Detail

Repository
R1029 Cookbook Creator
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6088
Build 6106: arc lint + arc unit
heikobecker requested review of this revision.Dec 16 2018, 7:41 PM
heikobecker created this revision.

doesn't add_library default to STATIC if not specified? Else we should add that keyword there rather than install the libs. They are just a convenience bundling of related bits in the source tree, not actual libraries.

Made it a static lib

Removed install line

heikobecker retitled this revision from Actually install libraries to Make libpanes a static library.Dec 16 2018, 8:09 PM
heikobecker edited the summary of this revision. (Show Details)
heikobecker edited the test plan for this revision. (Show Details)

Who sets BUILD_SHARED_LIBS ? I don't see anything in this cmake stuff doing it.

heikobecker added a comment.EditedDec 17 2018, 8:37 PM

Who sets BUILD_SHARED_LIBS ? I don't see anything in this cmake stuff doing it.

The user can for example, and most distros probably do so by default. As does KDECMakeSettings.cmake from ECM

svuorela accepted this revision.Dec 18 2018, 8:34 PM
This revision is now accepted and ready to land.Dec 18 2018, 8:34 PM
This revision was automatically updated to reflect the committed changes.