Differential D17621

Make RenameDialog modal again.
ClosedPublic
Actions

Authored by elvisangelaccio on Dec 16 2018, 12:30 PM.

Details

Reviewers
ngraham
Group Reviewers
VDG
Commits
R318:9581a2732829: Make RenameDialog modal again.
Summary

The rename dialog used to be modal, but commit
828ba8902ce16819a385832b487e60eab36e54ca changed the behavior without
really explaining why.

Test Plan

disable inline renaming and rename something.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Dolphin. · View Herald TranscriptDec 16 2018, 12:30 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
elvisangelaccio requested review of this revision.Dec 16 2018, 12:30 PM
ngraham accepted this revision.Dec 16 2018, 3:32 PM
ngraham added a subscriber: ngraham.

+1, modality makes sense here.

This revision is now accepted and ready to land.Dec 16 2018, 3:32 PM
Closed by commit R318:9581a2732829: Make RenameDialog modal again. (authored by elvisangelaccio). · Explain WhyDec 17 2018, 9:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47737

View Options

src/panels/folders/folderspanel.cpp

Loading...
View Options

src/views/dolphinview.cpp

Loading...