Differential D17613

Update Breeze color scheme's colors
ClosedPublic
Actions

Authored by ngraham on Dec 15 2018, 11:56 PM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:cb8b97a8f1e8: Update Breeze color scheme's colors
Summary

When I updated the colors of the systemwide Breeze color scheme last
year, I neglected to update the Konsole color scheme. This patch corrects
that oversight.

Colors taken from https://hig.kde.org/style/color/default.html

CCBUG: 391920

Test Plan

Overall, the contrast is much better than it was before.

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Dec 15 2018, 11:56 PM
Restricted Application added a project: Konsole. · View Herald TranscriptDec 15 2018, 11:56 PM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
ngraham requested review of this revision.Dec 15 2018, 11:56 PM
ngraham edited the test plan for this revision. (Show Details)Dec 15 2018, 11:58 PM
ngraham edited the summary of this revision. (Show Details)
hindenburg accepted this revision.Dec 17 2018, 3:39 PM
hindenburg added a subscriber: hindenburg.

No objection

This revision is now accepted and ready to land.Dec 17 2018, 3:39 PM
hindenburg edited the summary of this revision. (Show Details)Dec 17 2018, 3:40 PM
Closed by commit R319:cb8b97a8f1e8: Update Breeze color scheme's colors (authored by ngraham, committed by hindenburg). · Explain WhyDec 17 2018, 3:40 PM
This revision was automatically updated to reflect the committed changes.
ngraham added a comment.Dec 17 2018, 3:49 PM

While we're at it, could you help me figure out where the default color profile gets set? I can't find where _defaultColorScheme in ColorSchemeManager actually ever gets set.

hindenburg added a comment.Dec 18 2018, 2:08 AM
In D17613#378502, @ngraham wrote:

While we're at it, could you help me figure out where the default color profile gets set? I can't find where _defaultColorScheme in ColorSchemeManager actually ever gets set.

Profile.cpp

setProperty(ColorScheme, QStringLiteral("Linux")); //use DarkPastels when is start support blue ncurses UI properly
ngraham added a comment.Dec 18 2018, 4:28 AM

Thanks Kurt!

Revision Contents
Changeset List

Diff 47722

View Options

data/color-schemes/Breeze.colorscheme

Loading...