Details
- Reviewers
elvisangelaccio meven - Group Reviewers
Dolphin - Commits
- R318:bae6620f22d2: Use newly-upstreamed rename dialog from KIO
- Dolphin Settings > uncheck "rename inline"
- Rename one or more files. Observe that it still works
Tests still pass.
Diff Detail
- Repository
- R318 Dolphin
- Branch
- use-upstream-rename-dialog-from-kio (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 6044 Build 6062: arc lint + arc unit
The Frameworks version in question does not exist, this has broken the build of Dolphin.
See https://build.kde.org/view/Failing/job/Applications/job/dolphin/job/kf5-qt5%20SUSEQt5.12/lastFailedBuild
As Dolphin forms part of the dependencies of other projects and is therefore included in the Dependency Builds, i'm going to have to require you to revert this until David performs the version bump of Frameworks.
The Dependency Builds are currently required to all pass as their has been an ABI breakage in the underlying platform on FreeBSD (requiring them to run, otherwise we have no FreeBSD CI)
Sorry, I thought the version bump happened a few days ago, but that was for 5.66, not 5.67 (I always forget that frameworks version bumps happen at the end of the release cycle, not the beginning).
Reverted in 41105103b063c2e538bf0071e54fd429a841238b. Will commit again once 5.67 exists.
Just pushed this again because KIO 5.67 was tagged today, so landing it won't break the CI this time. Phab won't let me close this, so I guess I have to abandon it for some reason. :/