Added Fill Layer Content Option for New Documents
ClosedPublic

Authored by eoinoneill on Dec 14 2018, 11:13 PM.

Details

Reviewers
rempt
dkazakov
Group Reviewers
Krita
Summary

This patch also changes a few things about how new images are created by making use of enums in the newImage interface. I think I've also addressed the background opacity in a way that makes more sense and also allows for users to tweak background opacity settings after creating a new image. Lastly, while using RASTER or FILL backgrounds, if you create more than one layer the background layer will start locked. This helps to prevent accidental painting on initial starting background layers.

Test Plan

Try all the different permutations of New Document settings with different layer counts. Would also be interested in knowing how others feel about proposed design changes.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
eoinoneill created this revision.Dec 14 2018, 11:13 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptDec 14 2018, 11:13 PM
Restricted Application edited projects, added Krita; removed Krita: Abyss. · View Herald Transcript
eoinoneill requested review of this revision.Dec 14 2018, 11:13 PM

I'd put As Fill Layer in the third place. It might also be good to figure out a way to set the configuration of the fill layer, so people also create a fill layer with a pattern. For the rest, I like the changes.

eoinoneill updated this revision to Diff 47641.EditedDec 15 2018, 10:09 PM

I've changed the order of the options per request. Additionally, I've added some tooltips to make it more clear what given settings do.

I agree that it would be nice if pattern fill could be configured with a pattern, but I think that should be a separate patch since it may take more redesign and rethinking of the content tab (modal options depending users' background setting?) Also, it might be nice to add an additional ability to scale a fill layers' pattern.

rempt accepted this revision.Dec 15 2018, 10:14 PM

Yes, I agree that that should be in a separate patch.

This revision is now accepted and ready to land.Dec 15 2018, 10:14 PM
eoinoneill closed this revision.Dec 16 2018, 9:08 PM