Add Kdenlive + multimedia deps (MLT, codecs)
ClosedPublic
Actions

Authored by vpinon on Dec 14 2018, 10:10 PM.

Details

Reviewers

vonreth
kfunk

Group Reviewers

Windows

Commits

Summary

Add multimedia codecs to FFmpeg, add MLT, add Kdenlive

had to switch libogg, libvorbis, libsamplerate to autotools, as CMake patch misses pkg-config files for FFmpeg (this is only for GCC like compilers)
added x264, x265, libvpx for FFmpeg
added dlfcn, sdl2, frei0r for MLT
added MLT (+patch) & Kdenlive (+patch conflicting ARM builds)

Test Plan

builds & run on Linux (few changes since then)
builds on Windows with MinGW-64
- libogg.dll & libx265.dll manually merged
- runs well in Craft environment
- MLT incorrectly loading libmltavformat.dll else :( => help appreciated :)

Repository

R877 Craft Blueprints for KDE

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

vpinon requested review of this revision.Dec 14 2018, 10:10 PM

vpinon created this revision.

vpinon added a reviewer: Windows.

wow 😃

dev-utils/nasm/nasm.py
18	well if we can build it lets do that. Only take the binaries for msvc. 👍
kde/kdemultimedia/kdenlive/Qt-opengl-headers.patch
2	this patch was upstreamed?
kde/kdemultimedia/kdenlive/kdenlive.py
58	that means ffmpeg in craft won't run? If ogg uses a .def file we need to fix the dll name in there.
libs/dlfcn-win32/dlfcn-win32.py
10 ↗	(On Diff #47598)	sha256 pls
libs/frei0r-plugins/frei0r-plugins.py
11	sha256
15	no deps? at least depend on virtual/base
libs/libogg/libogg.py
33	we need to fix the import lib to reference the correct dll. The issue usually point to a wrong lib name in libogg.def
libs/libsdl2/libsdl2.py
11	sha256
21	as this is autotools only pls move it to libs/_autotools/...
libs/libvorbis/libvorbis.py
15	256
libs/libvpx/libvpx.py
7 ↗	(On Diff #47598)	256
17 ↗	(On Diff #47598)	libs/_autotools
libs/mlt/mlt.py
32 ↗	(On Diff #47598)	libs/_autotools
libs/x264/x264.py
20 ↗	(On Diff #47598)	265 and _autools
libs/x265/x265.py
9	256

This revision now requires changes to proceed.Dec 15 2018, 1:41 PM

Kdenlive now working :)

for ogg & vorbis, I just had to keep the existing .def patches /o\
for x265, I had to patch upstream CMakeFile to disable .pdb install
for Kdenlive problems (finding OpenGLES, melt.exe) I upstreamed the changes so the default target is now Applications/18.12 git branch
cleaned the digests to sha256, moved to _autotools the libs that needed it

Thanks again for support!

besides the ogg issue it looks good.
lets see what breaks :D

libs/libogg/libogg.py
31	As they forgot to package the cmake files with the tarball, could you catch them from the git and add them as a patch? (Discovered that yesterday when I had a look on the tarball, also the new cmake build system which they don't ship has pc files (not sure)

This revision is now accepted and ready to land.Dec 19 2018, 1:05 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		dev-utils/nasm/nasm.py (38 lines)
M		dev-utils/yasm/yasm.py (8 lines)
A	M	kde/kdemultimedia/kdenlive/Qt-opengl-headers.patch (96 lines)
A	M	kde/kdemultimedia/kdenlive/blacklist.txt (7 lines)
A	M	kde/kdemultimedia/kdenlive/kdenlive.py (68 lines)
A	M	libs/_autotools/libvpx/libvpx.py (25 lines)
A	M	libs/_autotools/mlt/mlt.py (41 lines)
A	M	libs/_autotools/mlt/run-exe-from-bin.patch (92 lines)
A	M	libs/_autotools/x264/x264.py (23 lines)
A	M	libs/_windows/dlfcn-win32/dlfcn-win32.py (18 lines)
M		libs/ffmpeg/ffmpeg.py (34 lines)
A	M	libs/frei0r-plugins/frei0r-plugins.py (26 lines)
M		libs/libogg/libogg.py (22 lines)
M		libs/libsamplerate/libsamplerate.py (17 lines)
A	M	libs/libsdl2/libsdl2.py (23 lines)
M		libs/libvorbis/libvorbis.py (23 lines)
A	M	libs/x265/mingw-no-pdb.patch (14 lines)
A	M	libs/x265/x265.py (22 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47598	5624734		Dec 14 2018, 10:10 PM	★	★
Diff 2	47797	fbefb04	Kdenlive now working :)	Dec 18 2018, 8:35 PM	★	★
Diff 3	47869	e8c5a55	R877:0ae1101d58d6fc71993962736cd0b7508a08c452	Dec 19 2018, 8:48 PM	★	★