Differential D17586

[libkwineffects] Use override keyword in AnimationEffect
AbandonedPublic
Actions

Authored by zzag on Dec 14 2018, 8:27 PM.

Details

Reviewers
None
Group Reviewers
KWin
Summary

Methods like prePaintWindow, prePaintScreen and so on won't be a subject
to change any time soon, in addition to that, they are not that special,
so it's okay to wreck the git history by adding the override keyword.

Test Plan

Scripted effects still work.

Diff Detail

Repository
R108 KWin
Branch
moderinize-animation-effect
Lint
Lint SkippedExcuse: arcanist is broken.
Unit
No Unit Test Coverage
Build Status
Buildable 6031
Build 6049: arc lint + arc unit
zzag created this revision.Dec 14 2018, 8:27 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 14 2018, 8:27 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 14 2018, 8:27 PM
davidedmundson added a subscriber: davidedmundson.Dec 14 2018, 10:37 PM

Cue the repeated discussion.
I don't want to review a thousand patches adding override.

zzag abandoned this revision.Dec 14 2018, 11:57 PM

Revision Contents
Changeset List

PathPackages
Mlibkwineffects/kwinanimationeffect.h (14 lines)

Diff 47592

View Options

libkwineffects/kwinanimationeffect.h

Loading...