| graesslin | |
| davidedmundson | |
| zzag |
| KWin |
Added support for libinput clickfinger , areas method for touchpad KCM
Also added mock methods.
Included commits in branch libinputClickMethod:
Added libinput mock methods Added : 1. setScrollMethod 2. added key value pair in QMap 3. added methods for Q_Props Added Q_Props for click method, signal Added variables and initialize in constructor
| Lint OK |
| No Unit Test Coverage |
| Buildable 6252 | |
| Build 6270: arc lint + arc unit |
Good start. Thanks.
| libinput/device.cpp | ||
|---|---|---|
| 364 | Current we switch modes, but there's also a: LIBINPUT_CONFIG_CLICK_METHOD_NONE Is there a need for the KCM to ever set libinput to this? If so as a general rule exposing a 3 state enum states as 2 bools can lead to things becoming more complicated. Especially if we have async connections to the config. | |
| 366 | In terms of whitespace we follow: | |
| libinput/device.h | ||
| 405 | The default and current methods are a single enum value not flags. i.e we can just compare here. | |
Yes Next I'm going to implement unit test once this get finalized
| libinput/device.cpp | ||
|---|---|---|
| 364 | If the user device already has physical buttons We need not to change anything default setting will be applicable and no ui will be exposed . else if it doesn't has physical buttons then user needs to select either areas or clickfinger mode So i don't think we ever need to set method as LIBINPUT_CONFIG_CLICK_METHOD_NONE | |
Added unit test
Changes made :
Recently I extended our test to verify dbus properties, see ba0cf19286bcbe731786e33bc96f62830e4ebcfc. Would be cool, if your test could also include these tests.
The code generates warnings:
/home/martin/src/kde/workspace/kwin/libinput/device.h:571:16: warning: ‘KWin::LibInput::Device::m_defaultCalibrationMatrix’ will be initialized after [-Wreorder]
QMatrix4x4 m_defaultCalibrationMatrix;
^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/martin/src/kde/workspace/kwin/libinput/device.h:562:13: warning: ‘quint32 KWin::LibInput::Device::m_supportedClickMethods’ [-Wreorder]
quint32 m_supportedClickMethods;
^~~~~~~~~~~~~~~~~~~~~~~
/home/martin/src/kde/workspace/kwin/libinput/device.cpp:154:1: warning: when initialized here [-Wreorder]
Device::Device(libinput_device *device, QObject *parent)