Allow configuring shortcut for Run Scratch action and add to Run menu
ClosedPublic

Authored by amhndu on Dec 13 2018, 5:17 PM.

Details

Summary

Add "Run Scratch" action to main window and thus allow configuring it.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
amhndu created this revision.Dec 13 2018, 5:17 PM
Restricted Application added a project: KDevelop. · View Herald TranscriptDec 13 2018, 5:17 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald Transcript
amhndu requested review of this revision.Dec 13 2018, 5:17 PM
kfunk accepted this revision.Jan 9 2019, 11:22 AM

I think that looks fine. Didn't test though.

This revision is now accepted and ready to land.Jan 9 2019, 11:22 AM
arrowd added a subscriber: arrowd.Jan 12 2019, 8:50 AM

I found the following minor issue:

When I just started KDevelop and open "Scratchpad" toolview, any action except "New Scratch" are greyed out. Even "Remove Scratch", as well as "Run Scratch". When I open any scratch, it turns back to normal, even if I again close all Sratchpad windows.

But that's not related to your change, so please push it. Not sure where to, 5.3, I guess.

I found the following minor issue:

When I just started KDevelop and open "Scratchpad" toolview, any action except "New Scratch" are greyed out. Even "Remove Scratch", as well as "Run Scratch". When I open any scratch, it turns back to normal, even if I again close all Sratchpad windows.

That's intended. The actions are all associated with the selected scratch in the toolview list. Switching the window to a different scratch also changes this selection, while closing a window keeps the selection.
Is this non-intuitive ?

But that's not related to your change, so please push it. Not sure where to, 5.3, I guess.

That would be master, the rest of the plugin hasn't been pushed to 5.3.

Thanks for testing this!

I found the following minor issue:

When I just started KDevelop and open "Scratchpad" toolview, any action except "New Scratch" are greyed out. Even "Remove Scratch", as well as "Run Scratch". When I open any scratch, it turns back to normal, even if I again close all Sratchpad windows.

That's intended. The actions are all associated with the selected scratch in the toolview list. Switching the window to a different scratch also changes this selection, while closing a window keeps the selection.

Not quite. I'm talking about menu that shows up when you right-click a scratch in the scratches list.

For example, I have 2 scratches: scr1.cpp and scr2.cpp. I left-click on first one and open it, then right-click on second one and select Run. The 2nd scratch gets executed.

But these actions are disabled until I open any scratch in the editor.

But that's not related to your change, so please push it. Not sure where to, 5.3, I guess.

That would be master, the rest of the plugin hasn't been pushed to 5.3.

Ah, then master, right.

For example, I have 2 scratches: scr1.cpp and scr2.cpp. I left-click on first one and open it, then right-click on second one and select Run. The 2nd scratch gets executed.

If I right-click the second scratch, it feels right to me that all the actions in the context-menu would correspond to that scratch, and it's selected.
What would you have preferred ?

But these actions are disabled until I open any scratch in the editor.

Oh sorry!
I only just understood the problem. Thanks, I'll note it and get to it later.

This revision was automatically updated to reflect the committed changes.