Differential D17566

Prevent Empty commands or messages from being sent
ClosedPublic
Actions

Authored by rizzitello on Dec 13 2018, 4:38 PM.

Details

Reviewers
laysrodrigues
tcanabrava
patrickelectric
Commits
R232:9f7d781d32ac: Prevent Empty commands or messages from being sent
R232:88aafecd13bb: Prevent Empty commands or messages from being sent
Summary

Before:
You could press send on the command widget and AtCore would send an empty message of \n\r to the printer. This could cause the machine to stop responding as atcore is waiting on a new ready state if the machine does not send "ok" after the empty command
After:
if there is no text to send there is no emit.

Diff Detail

Repository
R232 AtCore
Branch
disableAbilityEmptyCommands
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5996
Build 6014: arc lint + arc unit
rizzitello requested review of this revision.Dec 13 2018, 4:38 PM
rizzitello created this revision.
rizzitello edited the summary of this revision. (Show Details)Dec 13 2018, 4:40 PM
rizzitello added reviewers: laysrodrigues, tcanabrava, patrickelectric.
rizzitello added a project: Atelier: AtCore.
rizzitello added a subscriber: Atelier: AtCore.
laysrodrigues accepted this revision.Dec 13 2018, 4:41 PM
This revision is now accepted and ready to land.Dec 13 2018, 4:41 PM
patrickelectric accepted this revision.Dec 13 2018, 4:42 PM
rizzitello closed this revision.Dec 13 2018, 5:02 PM

Revision Contents
Changeset List

PathPackages
Msrc/widgets/commandwidget.cpp (14 lines)

Diff 47528

View Options

src/widgets/commandwidget.cpp

Loading...