Differential D17565

[libkwineffects] Don't mark a painted window as transformed twice
ClosedPublic
Actions

Authored by zzag on Dec 13 2018, 4:12 PM.

Details

Reviewers
davidedmundson
graesslin
Group Reviewers
KWin
Commits
R108:54bf5f1af69b: [libkwineffects] Don't mark a painted window as transformed twice
Summary

WindowPrePaintData::setTransformed sets PAINT_WINDOW_TRANSFORMED,
so data.mask |= PAINT_WINDOW_TRANSFORMED; is redundant.

Test Plan

Minimized a window, haven't noticed visual glitches.

Diff Detail

Repository
R108 KWin
Branch
dont-set-paint-window-transformed-again
Lint
Lint SkippedExcuse: Linting functionality in my local installation of arcanist is broken.
Unit
No Unit Test Coverage
Build Status
Buildable 5993
Build 6011: arc lint + arc unit
zzag created this revision.Dec 13 2018, 4:12 PM
Restricted Application added a project: KWin. · View Herald TranscriptDec 13 2018, 4:12 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Dec 13 2018, 4:12 PM
davidedmundson accepted this revision.Dec 13 2018, 4:29 PM
This revision is now accepted and ready to land.Dec 13 2018, 4:29 PM
graesslin accepted this revision.Dec 13 2018, 4:37 PM
Closed by commit R108:54bf5f1af69b: [libkwineffects] Don't mark a painted window as transformed twice (authored by zzag). · Explain WhyDec 14 2018, 7:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47523

View Options

libkwineffects/kwinanimationeffect.cpp

Loading...