Fix memory leak in notifications applet if only tracking jobs
ClosedPublic

Authored by davidedmundson on Dec 13 2018, 2:27 PM.

Details

Summary

There's an early return before the memory cleanup that happens at the
end of this function.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Dec 13 2018, 2:27 PM
Restricted Application added a project: Plasma. · View Herald TranscriptDec 13 2018, 2:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson requested review of this revision.Dec 13 2018, 2:27 PM
broulik added inline comments.
applets/notifications/package/contents/ui/Jobs.qml
70

What about here?

77

and here?

cover even more cases

broulik accepted this revision.Dec 17 2018, 8:23 AM

One could probably have cached the contents in a variable and then delete'd them right away without doing it before every return

This revision is now accepted and ready to land.Dec 17 2018, 8:23 AM
This revision was automatically updated to reflect the committed changes.