Certain input devices like touch screens can be in a state of having no input
target at all. In case of touch screens when there are no current touch points.
In this case unset and block at-surface targets until a touch point is
available again.
Details
Details
- Reviewers
davidedmundson - Group Reviewers
KWin - Commits
- R108:05ca6c97f83b: Unset touch targets on no current touch points
Auto test window-selection passes again.
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Thanks for fixing.
| touch_input.cpp | ||
|---|---|---|
| 88 | It's a weird name. I would suggest something like "positionValid". | |
| 140 | Unrelated. Though the change makes sense, consider it reviewed here. | |
| touch_input.cpp | ||
|---|---|---|
| 140 | It's not unrelated, because with this change this function always gets called when all touch points go away again. Before that the filter is run with the same code, which leads to two leave events, making another autotest fail. But I'll put it in a second commit and say in the message which other autotest fails otherwise (have to look it up again). | |