improve highlighting of complex numbers
ClosedPublic

Authored by cullmann on Dec 12 2018, 9:43 AM.

Details

Summary

CHANGELOG: support more variants of C number literals

BUG: 402002

Test Plan

adapted unit tests to cover problematic cases

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cullmann created this revision.Dec 12 2018, 9:43 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 12 2018, 9:43 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
cullmann requested review of this revision.Dec 12 2018, 9:43 AM
cullmann updated this revision to Diff 47430.Dec 12 2018, 9:44 AM

update unit tests

I didn't include rules as I need to rule out the user literal suffixes.

dhaumann accepted this revision.Dec 12 2018, 1:26 PM

Reviewing correct context popping is always not so easy - I trust this part is correct?! ;)

This revision is now accepted and ready to land.Dec 12 2018, 1:26 PM

It's "stolen" 1:1 from the C++ stuff.

This revision was automatically updated to reflect the committed changes.

Well, if it's copy & pasted, it must be correct ;)