Differential D17530

improve highlighting of complex numbers
ClosedPublic
Actions

Authored by cullmann on Dec 12 2018, 9:43 AM.

Details

Reviewers
dhaumann
vkrause
Group Reviewers
Frameworks
Commits
R216:ea5a88d1df28: improve highlighting of complex numbers
Summary

CHANGELOG: support more variants of C number literals

BUG: 402002

Test Plan

adapted unit tests to cover problematic cases

Diff Detail

Repository
R216 Syntax Highlighting
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 5951
Build 5969: arc lint + arc unit
cullmann created this revision.Dec 12 2018, 9:43 AM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptDec 12 2018, 9:43 AM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
cullmann requested review of this revision.Dec 12 2018, 9:43 AM
cullmann updated this revision to Diff 47430.Dec 12 2018, 9:44 AM

update unit tests

cullmann added reviewers: dhaumann, vkrause, Frameworks.Dec 12 2018, 9:45 AM

I didn't include rules as I need to rule out the user literal suffixes.

dhaumann accepted this revision.Dec 12 2018, 1:26 PM

Reviewing correct context popping is always not so easy - I trust this part is correct?! ;)

This revision is now accepted and ready to land.Dec 12 2018, 1:26 PM
cullmann added a comment.Dec 12 2018, 1:31 PM

It's "stolen" 1:1 from the C++ stuff.

Closed by commit R216:ea5a88d1df28: improve highlighting of complex numbers (authored by cullmann). · Explain WhyDec 12 2018, 1:39 PM
This revision was automatically updated to reflect the committed changes.
dhaumann added a comment.Dec 12 2018, 9:48 PM

Well, if it's copy & pasted, it must be correct ;)

Showing Only Differences

This revision modifies 2 more files that are hidden because they were not modified between selected diffs and they have no inline comments.

Revision Contents
Changeset List

Diff 47430

View Options

autotests/folding/test.c.fold

Loading...
View Options

autotests/html/test.c.html

Loading...
View Options

autotests/reference/test.c.ref

Loading...