[client] Detect errors in ConnectionThread
ClosedPublic

Authored by graesslin on Jun 3 2016, 9:27 AM.

Details

Summary

So far ConnectionThread dispatched events without checking for (protocol)
errors. But Wayland errors are considered fatal. We do need to consider
them.

This change introduces a way to detect errors and expose them in
ConnectionThread. Errors are handled gracefully, they are exposed, but
not considered application fatal. E.g. a new ConnectionThread could be
created afterwards.

This allows to add tests to verify error conditions.

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 4183.Jun 3 2016, 9:27 AM
graesslin retitled this revision from to [client] Detect errors in ConnectionThread.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 3 2016, 9:27 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
bshah accepted this revision.Jun 4 2016, 1:52 PM
bshah added a reviewer: bshah.
This revision is now accepted and ready to land.Jun 4 2016, 1:52 PM
This revision was automatically updated to reflect the committed changes.