Differential D17526

[autotests] Test window open/close animations
ClosedPublic
Actions

Authored by zzag on Dec 12 2018, 9:03 AM.

Details

Reviewers

graesslin

Group Reviewers

KWin

Commits

R108:e86d8461ed81: [autotests] Test window open/close animations

Summary

The idea behind this autotest is to verify that different window
open/close animation effects behave similarly.

Currently, we just check whether Fade/Glide/Scale effect tries to animate
the appearing or the disappearing of toplevels. In the future, the
autotest will be extended to verify that there are no conflicts between
those three effects and the Login/Logout effect, etc.

Test Plan

Ran the test, found a bug in the Fade effect, fixed it.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

zzag created this revision.Dec 12 2018, 9:03 AM

Restricted Application added a project: KWin. · View Herald TranscriptDec 12 2018, 9:03 AM

Restricted Application added a subscriber: kwin. · View Herald Transcript

zzag requested review of this revision.Dec 12 2018, 9:03 AM

Harbormaster completed remote builds in B5947: Diff 47423.Dec 12 2018, 9:03 AM

graesslin accepted this revision.Dec 12 2018, 5:44 PM

This revision is now accepted and ready to land.Dec 12 2018, 5:44 PM

Closed by commit R108:e86d8461ed81: [autotests] Test window open/close animations (authored by zzag). · Explain WhyDec 14 2018, 7:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		autotests/integration/effects/CMakeLists.txt (1 line)
A	M	autotests/integration/effects/toplevel_open_close_animation_test.cpp (218 lines)
M		effects/fade/package/contents/code/main.js (2 lines)